libxl: specify disks using supported command line syntax for new qemu
authorIan Campbell <ian.campbell@citrix.com>
Tue, 5 Apr 2011 16:34:48 +0000 (17:34 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Tue, 5 Apr 2011 16:34:48 +0000 (17:34 +0100)
commitd93b35f89b1c6715fb903d057782314759cab20c
treecedc2fb3db46cc47e77c35fc8cc5e21829ff4d16
parent55ccba217d0d33c476105b626dc681f863ccb7ae
libxl: specify disks using supported command line syntax for new qemu

The -hdX syntax is only retained for compatibility reasons and the
-sdX syntax doesn't even exist.

Additionally convert the first four non-SCSI disks to hd[a-d] and
ignore any further non-SCSI disks (since qemu only supports 4 IDE
devices).

SCSI disks are passed through as is. qemu-xen was limited to 7 SCSI
devices but upstream qemu supports 256, therefore do not limit the
number of disks on the libxl side.

qemu-xen did all this itself internally.

Fixes "qemu: -xvda: invalid option" and allows PVHVM to work with
upstream qemu.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_dm.c